Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insight) Keep the saved name of insight when creating a new SQL (… #28127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xu20160924
Copy link
Contributor

#27591)

Problem

#27591

Changes

preserve the saved name of insight if there has

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

self-hosted tested

How did you test this code?

self-hosted tested

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed a bug where SQL insight names would revert to default when re-running queries by modifying the insight state management.

  • Modified setInsight reducer in /frontend/src/scenes/insights/insightLogic.tsx to preserve existing insight name if no new name is provided in update
  • Ensures user-entered names persist through query re-runs and insight updates
  • Addresses customer-reported issue where SQL insight names would reset to default on query execution

💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant