-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(visual): upgrade playwright to capture canvas elements #28864
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: app.greptile.com/review/github.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Size Change: 0 B Total Size: 9.72 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated108 snapshot changes in total. 0 added, 108 modified, 0 deleted:
Triggered by this commit. |
# Conflicts: # frontend/__snapshots__/scenes-app-insights--funnel-historical-trends--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-historical-trends--light--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-left-to-right--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-left-to-right--light--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-left-to-right-breakdown--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-left-to-right-breakdown--light--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-left-to-right-breakdown-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-left-to-right-breakdown-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-left-to-right-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-left-to-right-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-time-to-convert--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-time-to-convert--light--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-time-to-convert-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-time-to-convert-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom--light--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-breakdown--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-breakdown--light--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-breakdown-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-breakdown-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--funnel-top-to-bottom-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--lifecycle--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--lifecycle--light--webkit.png # frontend/__snapshots__/scenes-app-insights--lifecycle-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--lifecycle-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--retention--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--retention--light--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-breakdown--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-breakdown--light--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-breakdown-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-breakdown-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--stickiness--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--stickiness--light--webkit.png # frontend/__snapshots__/scenes-app-insights--stickiness-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--stickiness-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-area--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-area--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-area-breakdown--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-area-breakdown--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-area-breakdown-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-area-breakdown-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-area-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-area-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-bar--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-bar--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-bar-breakdown--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-bar-breakdown--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-bar-breakdown-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-bar-breakdown-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-bar-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-bar-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-breakdown--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-breakdown--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-breakdown-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-breakdown-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-breakdown-labels--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-breakdown-labels--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-multi--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-multi--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-multi-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-line-multi-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-number--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-number--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-number-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-number-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-pie--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-pie--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-pie-breakdown--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-pie-breakdown--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-pie-breakdown-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-pie-breakdown-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-pie-breakdown-labels--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-pie-breakdown-labels--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-pie-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-pie-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-table--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-table--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-table-breakdown--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-table-breakdown--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-table-breakdown-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-table-breakdown-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-table-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-table-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-value--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-value--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-value-breakdown--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-value-breakdown--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-value-breakdown-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-value-breakdown-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-value-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-value-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-world-map--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-world-map--light--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-world-map-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--trends-world-map-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--user-paths--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--user-paths--light--webkit.png # frontend/__snapshots__/scenes-app-insights--user-paths-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--user-paths-edit--light--webkit.png
# Conflicts: # frontend/__snapshots__/scenes-app-insights--stickiness-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--stickiness-edit--light--webkit.png
# Conflicts: # frontend/__snapshots__/scenes-app-insights--retention--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--retention--light--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-breakdown--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-breakdown--light--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-breakdown-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-breakdown-edit--light--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-edit--dark--webkit.png # frontend/__snapshots__/scenes-app-insights--retention-edit--light--webkit.png
📸 UI snapshots have been updated279 snapshot changes in total. 0 added, 279 modified, 0 deleted:
Triggered by this commit. |
Problem
A recent version of playwright supposedly added support for capturing canvas elements: https://github.com/microsoft/playwright/releases/tag/v1.49.0. Let's try and see if it works.
Changes
Upgraded playwright to the latest version
How did you test this code?
CI run