Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdp): spike out new REST API in property-defs-rs #29096

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
296c03b
scaffold API router and handlers, query client, and spike out prop de…
eli-r-ph Feb 19, 2025
24f480a
capture property defs hardcoded lists from Django monolith source; re…
eli-r-ph Feb 20, 2025
d3dfced
milestone: ugly (prob buggy!) but complete, compiling, borrow-checker…
eli-r-ph Feb 21, 2025
29d0d78
wire up stub query execution and JSON response in routing module; spi…
eli-r-ph Feb 21, 2025
9da6aae
milestone: hacky (likely buggy!) impl of prop defs query completed. T…
eli-r-ph Feb 21, 2025
dbb97a0
remove unused event properties list cargo culted from Django monolith…
eli-r-ph Feb 21, 2025
0f83c94
wire up query result fetch from responses
eli-r-ph Feb 22, 2025
98ec7e4
linter! run cargo fmt over my smelly code
eli-r-ph Feb 22, 2025
64c1346
stub in conditional FROM clauses
eli-r-ph Feb 23, 2025
a329d30
parse req params in more idiomatic Rust way
eli-r-ph Feb 23, 2025
93e203a
DRY up query builder code
eli-r-ph Feb 23, 2025
a3377b8
another pass w/linter
eli-r-ph Feb 23, 2025
ca42f28
tiny bit more idiomatic param parsing
eli-r-ph Feb 23, 2025
9bf097c
abstract parsed req params
eli-r-ph Feb 24, 2025
bbbd82f
spike out very simple error handling & query param validation
eli-r-ph Feb 24, 2025
db893cb
appease linter: simplify property_type param access
eli-r-ph Feb 24, 2025
d2d2495
misc. greptile suggestions
eli-r-ph Feb 24, 2025
f6bac2b
more greptile suggestions
eli-r-ph Feb 24, 2025
a248e58
greptile: update Cargo.toml import syntax
eli-r-ph Feb 24, 2025
63951d9
cleanups: get count & prop defs stub queries working + temporarily de…
eli-r-ph Feb 25, 2025
379a994
nerf panic-on-query-fail while we iterate
eli-r-ph Feb 25, 2025
8dbd490
remove redundant request param
eli-r-ph Feb 25, 2025
05ba142
simplify search_fields init
eli-r-ph Feb 25, 2025
464892b
stub populate prop defs resp list
eli-r-ph Feb 25, 2025
fc1d7f5
post-review: move table name placeholders into constants pkg
eli-r-ph Feb 25, 2025
a598f21
post-review: simplify arg capture to make query build step easier
eli-r-ph Feb 25, 2025
c06a637
small tweak to simplify limit/offset handling
eli-r-ph Feb 25, 2025
a580a9e
add anyhow lib to property-defs-rs (imported from workspace)
eli-r-ph Feb 25, 2025
de6690b
post-review: convert error handling to use anyhow and thiserror
eli-r-ph Feb 25, 2025
ff64bbd
small tweak to make request param error handling nicer
eli-r-ph Feb 25, 2025
460ad4a
post-review: move query::Manager into AppContext
eli-r-ph Feb 25, 2025
6948f1a
ws
eli-r-ph Feb 25, 2025
b29f794
post-review: first iter of deserializing direct from row (more to com…
eli-r-ph Feb 26, 2025
0064921
fix small enterprise-taxonomy scoped q typo; prep for conditional Use…
eli-r-ph Feb 26, 2025
e62c407
linter
eli-r-ph Feb 26, 2025
2b3b9bb
moar linter
eli-r-ph Feb 26, 2025
5162bd5
moar moar linter
eli-r-ph Feb 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions rust/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions rust/property-defs-rs/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ common-kafka = { path = "../common/kafka" }
ahash = { workspace = true }
uuid = { workspace = true }
rand = { workspace = true }
url = { workspace = true }
anyhow = { workspace = true }
thiserror.workspace = true

[lints]
workspace = true
6 changes: 6 additions & 0 deletions rust/property-defs-rs/src/api/mod.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
pub mod v1 {
pub mod constants;
pub mod errors;
pub mod query;
pub mod routing;
}
Loading