feat: add more details to NPS score [part 2] #29112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the NPS (Net Promoter Score) visualization in survey results by adding a detailed breakdown view.
- Added new reusable
StackedBarcomponent in/frontend/src/scenes/surveys/surveyViewViz.tsxfor consistent bar chart visualization - Implemented
NPSStackedBarcomponent to display percentage breakdown of promoters, passives, and detractors - Added tooltip in survey view explaining NPS score calculation methodology
- Refactored
UsersStackedBarto leverage the newStackedBarcomponent for consistency - Enhanced survey results view with color-coded segments showing relative proportions of each NPS category
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| {/* eslint-disable-next-line react/forbid-dom-props */} | ||
| <div className="w-3 h-3 rounded-full mr-2" style={style} /> | ||
| <div key={`stacked-bar-legend-${label}`} className="flex items-center mr-6"> | ||
| {} |
There was a problem hiding this comment.
style: Empty JSX fragment {} can be removed
Suggested change
| {} |
lucasheriques
force-pushed
the
feat/add-more-details-to-nps-score-part-2
branch
from
4ec9698 to
8ba698a
Compare
|
Size Change: 0 B Total Size: 9.72 MB ℹ️ View Unchanged
|
marandaneto
reviewed
Feb 23, 2025
marandaneto
reviewed
Feb 23, 2025
marandaneto
reviewed
Feb 23, 2025
marandaneto
reviewed
Feb 23, 2025
|
Nice, cool stuff. |
Base automatically changed from
feat/add-more-details-to-nps-score
to
master
February 25, 2025 14:25
marandaneto
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
currently, our NPS score view is limited, because while it shows the score, it doesn't show the % of detractors, passive or promoters.
Changes
before:
after:
adds a new StackBar reusable component, now used for both NPS Breakdown and Survey Stats.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
yes
How did you test this code?
unit tests on the previews PR