feat: count playlists with filters #29113
Open
+477
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pauldambra
commented
Feb 23, 2025
•
pauldambra
commented
- adds a task that finds playlists with filters for teams on an allowlist
- adds a task that runs those filters and stores results in redis
- returns the count of filters or pinned when listing playlists
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds functionality to count and cache the number of recordings matching playlist filters, with controlled rollout to specific teams.
- Added new Celery task
count_recordings_that_match_playlist_filtersin/ee/session_recordings/playlist_counters/recordings_that_match_playlist_filters.pythat runs every 15 seconds, which seems too frequent for this operation - Implemented Redis caching with 36-hour TTL in
/ee/session_recordings/playlist_counters/recordings_that_match_playlist_filters.pybut lacks cache invalidation strategy - Added team allowlist via
TEAMS_WITH_PLAYLIST_COUNTER_PROCESSINGin/posthog/settings/session_replay.pyfor controlled feature rollout - Missing error handling for Redis connection failures in
/ee/session_recordings/session_recording_playlist.py - Potential race condition in
/ee/session_recordings/playlist_counters/recordings_that_match_playlist_filters.pywhen multiple tasks update the same playlist count simultaneously
9 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
ee/session_recordings/playlist_counters/recordings_that_match_playlist_filters.py
Outdated
Show resolved
Hide resolved
frontend/src/scenes/session-recordings/saved-playlists/SavedSessionRecordingPlaylists.tsx
Outdated
Show resolved
Hide resolved
frontend/src/scenes/session-recordings/saved-playlists/SavedSessionRecordingPlaylists.tsx
Outdated
Show resolved
Hide resolved
|
Size Change: +133 B (0%) Total Size: 9.72 MB ℹ️ View Unchanged
|
pauldambra
force-pushed
the
feat/count-playlists
branch
from
b98649c to
30e12c7
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.