feat: New grouped invocation logs view #29131
Merged
+794
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 9.72 MB ℹ️ View Unchanged
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a new grouped invocation logs view for hog functions, enhancing the logging experience with invocation-based grouping and expanded functionality.
- Added new
HogFunctionLogscomponent infrontend/src/scenes/pipeline/PipelineNode.tsxthat groups logs by invocation ID - Implemented expandable rows to load older/newer logs when clicked
- Added filtering capability to show invocations where any result contains the search term
- Fixed bug in
posthog/api/hog_function.pythat was resetting bytecode when the hog field wasn't included in requests - Added retry button functionality for errored events
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
MarconLP
requested changes
Feb 25, 2025
Comment on lines
+29
to
+45
| return { | ||
| event: { | ||
| uuid, | ||
| distinct_id, | ||
| event, | ||
| properties: JSON.parse(properties), | ||
| timestamp, | ||
| url: '', | ||
| elements_chain: '', | ||
| }, | ||
| person: { | ||
| id: person_id, | ||
| properties: JSON.parse(person_properties), | ||
| url: '', | ||
| name: '', | ||
| }, | ||
| } |
There was a problem hiding this comment.
This will break retries for functions that are using group, project, or source values.
There was a problem hiding this comment.
That's true 🤔
Although the intention was to get that stuff done via the API rather than rebuilding everything client side which is a little less reliable.
In reality almost nothing uses those elements but still should fix it...
MarconLP
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The logs view is somewhat limited as it is just a list without any grouping.
This modifies it to allow grouping by instance_id (invocation)
Changes
TODO
FOLLOW UP
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?