fix: reload available features upgraded #29161
Open
+48
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances feature availability synchronization after billing changes in PostHog. Here's a concise summary of the key changes:
- Added
update_available_product_featuresmethod inbilling_manager.pyto fetch and update organization features from billing service - Integrated feature reloading in
billingLogic.tsxby callingloadCurrentOrganizationafter billing upgrades - Added automatic feature refresh after trial activation/cancellation in billing manager
- Removed unused
plan_keysparameter fromget_billingmethod for cleaner code
The changes ensure that users immediately see their updated feature access after any billing-related changes without requiring a page refresh.
2 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: +332 B (0%) Total Size: 9.72 MB ℹ️ View Unchanged
|
patricio-posthog
approved these changes
Feb 25, 2025
zlwaterfield
commented
Feb 25, 2025
| billing_manager = self.get_billing_manager() | ||
| query = {} | ||
| if "include_forecasting" in request.query_params: | ||
| query["include_forecasting"] = request.query_params.get("include_forecasting") | ||
| response = billing_manager.get_billing(org, plan_keys, query) | ||
| response = billing_manager.get_billing(org, query) |
There was a problem hiding this comment.
Clean up of unused arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Following up on https://github.com/PostHog/billing/pull/1121.
After a user upgrades, this is meant to make sure the latest available features are loaded.
Paths for when they need to be reloaded
This PR handles all of the above. There is much room to improve here how we sync avail features to organizations but this is a big improvement to the UX because right now the proper features are not loaded in until you refresh.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?