-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdp): record httpCalls for destinations #29186
Open
meikelmosby
wants to merge
19
commits into
master
Choose a base branch
from
feat/cdp/http-request-recordings-for-destinations-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(cdp): record httpCalls for destinations #29186
meikelmosby
wants to merge
19
commits into
master
from
feat/cdp/http-request-recordings-for-destinations-v2
+978
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Implemented HTTP call recording for destinations to support migration from VM2 to inlined JavaScript transformations, focusing on capturing request/response details for comparison.
- Added
recorded-fetch.ts
utility that wrapstrackedFetch
to record HTTP requests and responses without altering functionality - Integrated recording in
run.ts
with conditional activation based onDESTINATION_MIGRATION_DIFFING_ENABLED
flag - Created global HTTP call recorder in
imports.ts
with both direct and conditional recording functions - Added comprehensive test coverage in
vm-recorded-fetch.test.ts
andrecorded-fetch.test.ts
for various scenarios - Implemented proper cleanup to prevent memory leaks and detailed logging of request/response information
7 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
benjackwhite
requested changes
Feb 26, 2025
benjackwhite
requested changes
Feb 26, 2025
benjackwhite
requested changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Just as we migrated the old JavaScript transformations running in VM2 to inlined JavaScript transformations, we want to apply the same approach to destinations. Given the challenges we encountered with transformations, we need to take a more structured approach. The key aspects of destinations are HTTP calls and their responses, so we need a solution that records outgoing HTTP requests and their corresponding responses. By comparing these, we can ensure confidence in the migration.
Changes
I've implemented an HTTP recorder that captures and logs HTTP requests and their responses during plugin execution. This enhancement focuses on recording HTTP calls made by plugins during event processing without modifying the existing fetch implementation.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?