feat: Persist retried hog function logs #29193
Open
+219
−289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 9.72 MB ℹ️ View Unchanged
|
# Conflicts: # frontend/src/scenes/pipeline/hogfunctions/logs/hogFunctionLogsLogic.ts
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a centralized approach to handling logs and metrics for hog functions through a new HogFunctionMonitoringService class, focusing on persisting logs during retries.
- Added new
HogFunctionMonitoringServiceclass that centralizes log and metric production functionality - Modified
CdpCyclotronWorkerto use the monitoring service for processing invocation results and producing messages - Added support for custom invocation IDs in the API to maintain log continuity across retries
- Updated
cdp-api.tsto handle ClickHouse events and ensure logs are properly persisted even in error cases - Refactored
CdpProcessedEventsConsumerto use the monitoring service instead of direct log/metric production - Simplified API interfaces in Python code by using a more flexible payload-based approach
9 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+37
to
+39
| .catch((reason) => { | ||
| status.error('⚠️', `failed to produce message: ${reason}`) | ||
| }) |
There was a problem hiding this comment.
style: Error is logged but not propagated. Consider returning a result indicating success/failure or throwing the error to allow callers to handle it.
| this.messagesToProduce.push({ | ||
| topic: KAFKA_EVENTS_PLUGIN_INGESTION, | ||
| value: convertToCaptureEvent(event, team), | ||
| key: `${team!.api_token}:${event.distinct_id}`, |
There was a problem hiding this comment.
syntax: The non-null assertion operator (!) is redundant here since the if-check on line 112 already ensures team is not null.
Suggested change
| key: `${team!.api_token}:${event.distinct_id}`, | |
| key: `${team.api_token}:${event.distinct_id}`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow up from other PR
Changes
Follow up
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?