Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdp): fix broken tsconfig #29194

Merged
merged 1 commit into from
Feb 25, 2025
Merged

fix(cdp): fix broken tsconfig #29194

merged 1 commit into from
Feb 25, 2025

Conversation

meikelmosby
Copy link
Contributor

Problem

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@posthog-bot
Copy link
Contributor

Hey @meikelmosby! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR modifies the plugin-server's TypeScript configuration to include the tests directory in the compilation process, ensuring type-checking for test files.

  • Added tests directory to the include array in plugin-server/tsconfig.json to enable TypeScript type-checking for test files
  • This change aligns with the existing Jest configuration that already looks for tests in both src and tests directories
  • Type-checking test files helps catch type errors during development rather than at runtime
  • The modification is particularly relevant for CDP (Customer Data Platform) functionality tests

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@meikelmosby meikelmosby enabled auto-merge (squash) February 25, 2025 16:07
@meikelmosby meikelmosby merged commit b01f4e8 into master Feb 25, 2025
89 of 90 checks passed
@meikelmosby meikelmosby deleted the fix/cdp/fix-tsconfig branch February 25, 2025 16:10
fuziontech added a commit that referenced this pull request Feb 25, 2025
* master:
  fix(cdp): fix broken tsconfig (#29194)
  fix: move billing load to another logic (#29191)
  fix: check if questionResults is not null/undefined (#29187)
  chore(editor-3001): remove loading bar flag (#29155)
  fix(sql): too eager nested aggregation error (#29176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants