-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add inherit option for survery font customization #29199
Merged
lucasheriques
merged 6 commits into
master
from
chore/add-inherit-option-for-surveys-font-customization
Feb 25, 2025
Merged
chore: add inherit option for survery font customization #29199
lucasheriques
merged 6 commits into
master
from
chore/add-inherit-option-for-surveys-font-customization
Feb 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added an 'inherit' font family option to surveys, allowing users to match their website's font for better integration.
- Added
inherit
option toWEB_SAFE_FONTS
in/frontend/src/scenes/surveys/constants.tsx
, changing from string array to objects withvalue
andlabel
properties - Updated
SurveyAppearance
type in/frontend/src/types.ts
to use the new structure withfontFamily: (typeof WEB_SAFE_FONTS)[number]['value']
- Added
.inherit
CSS class in/frontend/src/styles/base.scss
that setsfont-family: inherit
- Updated font family selection UI in
/frontend/src/scenes/surveys/SurveyCustomization.tsx
with a TODO to specify minimum posthog-js version required
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
marandaneto
approved these changes
Feb 25, 2025
Size Change: -132 B (0%) Total Size: 9.72 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Depends on PostHog/posthog-js#1763
Adds the option to
inherit
font family on Surveys.It's the one that probably makes more sense for customers - uses the same font as their website.
Has one TODO before merging: adding the minimum version to use this feature. Will be done once the SDK PR is merged and I know the version.
Does this work well for both Cloud and self-hosted?
yes
How did you test this code?
verified locally if font family is being updated