fix: Silence several TS errors from plugin-server tests #29200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuziontech
approved these changes
Feb 25, 2025
rafaeelaudibert
force-pushed
the
fix-plugin-test-types
branch
from
94dcf1c to
a90cdfe
Compare
mariusandra
approved these changes
Feb 25, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses TypeScript errors in the plugin-server tests to make the master branch mergeable again.
- Added
@types/kafkajs-snappyas a dev dependency to fix missing type definitions - Made
processPersonparameter optional with default valuefalseinEventsProcessor.processEvent() - Added non-null assertions (
!) to properties and methods that TypeScript couldn't guarantee exist - Added
@ts-expect-errorcomments with TODOs for more complex type issues that need future fixes - Fixed incorrect type assertions by properly importing and using types like
ProjectIdandInternalPerson - Corrected function parameters by adding missing required arguments or replacing
nullwith appropriate values - Removed the unused
WaitEventclass frompromises.tshelper file
41 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
rafaeelaudibert
force-pushed
the
fix-plugin-test-types
branch
3 times, most recently
from
2572777 to
328be24
Compare
rafaeelaudibert
force-pushed
the
fix-plugin-test-types
branch
from
328be24 to
069dc09
Compare
rafaeelaudibert
commented
Feb 25, 2025
| @@ -4,7 +4,6 @@ import { mkdirSync, readdirSync, rmSync } from 'node:fs' | |||
| import { Message, TopicPartitionOffset } from 'node-rdkafka' | |||
| import path from 'path' | |||
|
|
|||
| import { waitForExpect } from '../../../../functional_tests/expectations' | |||
There was a problem hiding this comment.
TS can't find this file, don't ask me why, just inlined it
|
Size Change: 0 B Total Size: 9.72 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CI is broken because we're typechecking this
The problem is that a lot of these types are actually wrong, so let's fix the easy ones and silence the harder ones - I just need master to be mergeable once again