fix: add react to product analytics onboarding #29247
Merged
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds React as an option in the product analytics onboarding flow, addressing a missing SDK option in the platform.
- Added
ProductAnalyticsReactInstructionscomponent in new filefrontend/src/scenes/onboarding/sdks/product-analytics/react.tsxthat combines existing React SDK installation instructions with common JS final steps - Added mapping for
SDKKey.REACTtoProductAnalyticsReactInstructionsinfrontend/src/scenes/onboarding/sdks/product-analytics/ProductAnalyticsSDKInstructions.tsx - Exported React component via
export * from './react'infrontend/src/scenes/onboarding/sdks/product-analytics/index.tsx - Updated
frontend/src/scenes/onboarding/sdks/sdk-install-instructions/react.tsxto remove create-react-app specific references since it's been sunsetted
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: 0 B Total Size: 9.73 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
zlwaterfield
approved these changes
Feb 27, 2025
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Where is React? 🤷♂️
Changes
We got it in there just after create-react-app was sunsetted, but at least it'll be there.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Ran locally