chore: Delete persons workflow retries forever #29255
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
commented
Feb 26, 2025
| start_to_close_timeout=dt.timedelta(hours=2), | ||
| start_to_close_timeout=dt.timedelta(minutes=5), |
There was a problem hiding this comment.
Reduced this as it seemed too much just to mogrify a few queries.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the delete persons workflow to retry indefinitely on failures, eliminating the need for manual intervention after worker restarts.
- Changed
mogrify_delete_queries_activitytimeout from 2 hours to 5 minutes to better match this preparatory activity's typical duration - Set
maximum_attempts=0(infinite retries) in retry policies for both activities, replacing the previous limit of 1 attempt - Increased
maximum_intervalfordelete_persons_activityretry policy from 60 to 360 seconds, allowing longer backoff periods between retries - These changes ensure the workflow can automatically recover from transient failures without manual intervention
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
tomasfarias
commented
Feb 26, 2025
| @@ -235,8 +235,8 @@ async def run(self, inputs: DeletePersonsWorkflowInputs): | |||
| start_to_close_timeout=dt.timedelta(hours=2), | |||
| retry_policy=temporalio.common.RetryPolicy( | |||
| initial_interval=dt.timedelta(seconds=10), | |||
| maximum_interval=dt.timedelta(seconds=60), | |||
| maximum_attempts=1, | |||
| maximum_interval=dt.timedelta(seconds=360), | |||
There was a problem hiding this comment.
Bumped this in case we enter a retry loop, to have more time in between and not contribute to whatever is causing the retry loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Delete persons workflow runs without problems, but worker restarts can cause it to fail and have to be manually retried.
Changes
Let Temporal handle retrying by setting a RetryPolicy without retry limit.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?