feat: Add Web Analytics to Onboarding + Quick Start #29273
Conversation
rafaeelaudibert
changed the base branch from
master
to
revert-29250-revert-29083-use-app-urls-for-web-analytics
|
Size Change: +843 B (+0.01%) Total Size: 9.73 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds Web Analytics to the onboarding process and Quick Start guide, focusing on helping users properly set up authorized domains (app_urls) which are essential for Web Analytics functionality.
- Added
OnboardingWebAnalyticsAuthorizedDomainsStepcomponent that guides users through domain setup during onboarding - Created new
WebAnalyticsFilterscomponent with domain filtering capabilities, replacing inline filters in the dashboard - Added Web Analytics section to the activation sidebar with "Add an authorized domain" and "Set up web vitals" tasks
- Renamed
TeamToolbarURLstoTeamAuthorizedURLswith updated text explaining URLs are used for both Web Analytics and Web Experiments - Added health check warning in Web Analytics when no authorized domains are configured
42 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/layout/navigation-3000/sidepanel/panels/activation/activationLogic.tsx
Show resolved
Hide resolved
frontend/src/lib/components/AuthorizedUrlList/AuthorizedUrlForm.tsx
Outdated
Show resolved
Hide resolved
frontend/src/lib/components/AuthorizedUrlList/AuthorizedUrlForm.tsx
Outdated
Show resolved
Hide resolved
frontend/src/scenes/onboarding/web-analytics/OnboardingWebAnalyticsAuthorizedDomainsStep.tsx
Show resolved
Hide resolved
rafaeelaudibert
force-pushed
the
revert-29250-revert-29083-use-app-urls-for-web-analytics
branch
from
2858b6e to
c5c19a1
Compare
|
@rafaeelaudibert looks like this is still including a lot of changes from a previous PR |
@joshsny Yeah, we did a rebase, I'm fixing this, will ping you in 30min once this is ready for you :) |
Now that adding a domain to the authorized URLs list is very important to use Web Analytics properly, let's add it to the brand new Quick Start guide as well
rafaeelaudibert
force-pushed
the
add-domain-setup-to-web-analytics-onboarding
branch
from
0a1537a to
35334af
Compare
|
@joshsny Rebased now, should be good to review! |
| return | ||
| } | ||
|
|
||
| setAllOnboardingSteps(allSteps) |
There was a problem hiding this comment.
Do we need to do this useEffect? Can't see it being used elsewhere, I think currently just the allSteps state variable is used in this component
| } | ||
|
|
||
| if (payload?.app_urls && payload?.app_urls.length > 0) { | ||
| activationLogic.findMounted()?.actions?.markTaskAsCompleted(ActivationTask.AddAuthorizedDomain) |
There was a problem hiding this comment.
This didn't go anywhere for me, should I have a feature flag on?
Problem
Web Analytics now requires
app_urlsto be properly set-up if we want our customers to make the most out of it.Changes
Changes are 2-fold:
On the
/productsonboarding, display theapp_urlsUI inlineOn the Quick Start guide on the sidebar
Does this work well for both Cloud and self-hosted?
Yep
How did you test this code?
Manually