feat(lemon-ui): Make KeyboardShortcut Tooltip-compatible #29279
+36
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
changed the title
|
Size Change: -38 B (0%) Total Size: 9.73 MB ℹ️ View Unchanged
|
This comment was marked as off-topic.
This comment was marked as off-topic.
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Have wanted to use the KeyboardShortcut component in Max's submit button tooltip – found that tooltips currently look crap within tooltips.
Changes
Tooltips blending much better in tooltips now.
Also KeyboardShortcut now uses the semantic HTML tag
kbd.How did you test this code?
TODO: StorybookUpdate stories.