fix(web-analytics): Fix using a cohort internal test filter in web overview #29308
+166
−80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See https://posthoghelp.zendesk.com/agent/tickets/22891
If you have a cohort as an internal test filter, the web overview query errors, because the inner query defines
person_id
, but the cohort filter also tries to useperson_id
to meanevents.person_id
.Changes
Rename the
person_id
tosession_person_id
to avoid the collisionDoes this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Added a previously-failing test, which passes with this fix.