chore: add Discord notification template #29311
Open
+48
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds Discord notification templates for error tracking events and refactors existing templates for better consistency across platforms.
- Added new
error-tracking-issue-createdanderror-tracking-issue-reopenedsub-templates toSUB_TEMPLATE_COMMONin/posthog/cdp/templates/hog_function_template.py - Updated
/posthog/cdp/templates/discord/template_discord.pywith new sub-templates for error tracking notifications - Refactored
/posthog/cdp/templates/slack/template_slack.pyto use common sub-template definitions instead of hardcoded values - Modified
/posthog/cdp/templates/microsoft_teams/template_microsoft_teams.pyto reference centralized sub-template definitions for consistency
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+97
to
+98
| description="", | ||
| id=SUB_TEMPLATE_COMMON["error-tracking-issue-created"].id, |
There was a problem hiding this comment.
style: Empty description field. Consider adding a descriptive message similar to other sub-templates for consistency.
Suggested change
| description="", | |
| id=SUB_TEMPLATE_COMMON["error-tracking-issue-created"].id, | |
| description="Posts a message to Discord when a new issue is created", | |
| id=SUB_TEMPLATE_COMMON["error-tracking-issue-created"].id, |
Comment on lines
+109
to
+110
| description="", | ||
| id=SUB_TEMPLATE_COMMON["error-tracking-issue-reopened"].id, |
There was a problem hiding this comment.
style: Empty description field. Consider adding a descriptive message similar to other sub-templates for consistency.
Suggested change
| description="", | |
| id=SUB_TEMPLATE_COMMON["error-tracking-issue-reopened"].id, | |
| description="Posts a message to Discord when an issue is reopened", | |
| id=SUB_TEMPLATE_COMMON["error-tracking-issue-reopened"].id, |
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add template to notify errors on Discord