chore(data-warehouse): Wait for compaction to complete #29325
Merged
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the Delta Lake compaction process by ensuring it completes before proceeding with S3 file operations.
- Added wait logic in
trigger_compaction_job()to block until compaction workflow completes when not in DEBUG/TEST mode - Added detailed logging for compaction operations in
compact_table()method, capturing and logging both compact and vacuum statistics - Added support for "deltalake-compaction-job" workflow type in the logger to properly extract log source ID and set log source name
- Improved observability of the compaction process through structured JSON logging of operation results
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
phixMe
reviewed
Feb 27, 2025
| @@ -35,6 +36,10 @@ def trigger_compaction_job(job: ExternalDataJob, schema: ExternalDataSchema) -> | |||
| ), | |||
| ) | |||
| ) | |||
|
|
|||
| if not DEBUG and not TEST: | |||
There was a problem hiding this comment.
Is there a reason to not do this in the test environment?
There was a problem hiding this comment.
Yeah we don't run both jobs concurrently in tests. I think it'd be a pain in the ass to set up properly
phixMe
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes