fix(data-warehouse): Revert "feat(data-warehouse): New snowflake source" #29338
+8
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8fef3f6.
Gilbert09
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR reverts the addition of a dedicated Snowflake data source connector (#29317), returning to the previous implementation approach.
- Removed
posthog/temporal/data_imports/pipelines/snowflake/snowflake.pywhich contained specialized Snowflake connection and query functionality - Modified
import_data_sync.pyto importsnowflake_sourcefrom the generic SQL database module instead of the dedicated Snowflake module - Downgraded
snowflake-connector-pythonfrom version 3.13.2 to 3.6.0 in both requirements files - Added optional
team_idparameter to MySQL source function to maintain compatibility with the data import workflow interface - Updated comments in test files to accurately reflect the behavior of delta lake operations
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
MichaelKutsch-ph
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #29317
https://posthog.slack.com/archives/C0113360FFV/p1740735304798339