Fix font #534
Merged
Fix font #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@itexpert120 Thanks for the PR. What exactly is the issue that you are fixing here? I ran your branch but the 600-weight fonts are too heavy. I'm not sure what the issue is with the original. |
|
The fix is split between two PRs, both need to be merged. The one in bos-app removes all font imports and changes the font name to match its original font name "Mona Sans" instead of "Mona-Sans". The second PR in gateway adds the font which is hosted locally/ on the same server public address and loads it.
This way the Mona Sans font can be used.
The current implementation does not work and usually falls back to system default. If you see console logs you will know that it gets 403 forbidden error.
…________________________________
From: Lachlan Glen ***@***.***>
Sent: Saturday, April 13, 2024 11:35:38 PM
To: PotLock/bos-app ***@***.***>
Cc: Zeeshan Ahmad ***@***.***>; Mention ***@***.***>
Subject: Re: [PotLock/bos-app] Fix font (PR #534)
@itexpert120<https://github.com/itexpert120> Thanks for the PR. What exactly is the issue that you are fixing here?
I ran your branch but the 600-weight fonts are too heavy. I'm not sure what the issue is with the original.
—
Reply to this email directly, view it on GitHub<#534 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALC7FSWVZQFF6T37EKUBSO3Y5F3HVAVCNFSM6AAAAABGFE63XSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJTG4ZDMNZVG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Ok, thanks for the info. I merged the gateway PR and that has deployed, so I'll approve and merge this now. |
lachlanglen
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.