Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add/update group logic #75

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix add/update group logic #75

merged 1 commit into from
May 22, 2024

Conversation

lachlanglen
Copy link
Contributor

  • Allows for creation of groups with empty sets of providers
  • Splits out create_group and update_group into separate methods, instead of a single add_or_update_group method (NB: events remain the same, following the pattern established with other resources, e.g. providers)
  • Adds assert_valid_providers_vec validation method that panics if exact set of providers already exists in another group, and ignores if it is an empty set

Resolves #73
Resolves #74

@lachlanglen lachlanglen requested a review from carina-akaia May 22, 2024 15:50
@lachlanglen lachlanglen merged commit 30bf414 into feat/sybil-v2-new May 22, 2024
@lachlanglen lachlanglen deleted the fix/add-update-group branch May 22, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carina-akaia carina-akaia carina-akaia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lachlanglen @carina-akaia