Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to improve freshness-check description #14905

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Try to improve freshness-check description #14905

wants to merge 1 commit into from

Conversation

klaus-nicat
Copy link
Contributor

Short description

Try to improve freshness-check description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@Habbie Habbie added this to the auth-5 milestone Nov 29, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12087511287

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 55 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.002%) to 64.692%
Files with Coverage Reduction New Missed Lines %
pdns/pollmplexer.cc 1 83.66%
pdns/recursordist/aggressive_nsec.cc 2 66.32%
pdns/sstuff.hh 2 56.83%
pdns/ws-auth.cc 2 80.8%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/stubresolver.cc 3 77.58%
pdns/recursordist/recpacketcache.hh 3 89.55%
modules/gpgsqlbackend/spgsql.cc 3 68.18%
pdns/packethandler.cc 4 72.35%
pdns/recursordist/syncres.cc 6 79.33%
Totals Coverage Status
Change from base Build 12087438521: -0.002%
Covered Lines: 125837
Relevant Lines: 163644
💛 - Coveralls

miodvallat
miodvallat approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, minor style suggestions, feel free to dismiss them.

docs/modes-of-operation.rst
randomly select one of the configured primaries. If the freshness checks fails
for that primary, the zone will be checked again in the next cycle, again
using randomly one of the configured primaries. Hence, even with multiple primaries
make sure that always all of them are available for fast zone updates. If
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
make sure that always all of them are available for fast zone updates. If
make sure that all of them are always available for fast zone updates. If

docs/modes-of-operation.rst
'master' field of the domains table. For the freshness check PowerDNS will
randomly select one of the configured primaries. If the freshness checks fails
for that primary, the zone will be checked again in the next cycle, again
using randomly one of the configured primaries. Hence, even with multiple primaries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
using randomly one of the configured primaries. Hence, even with multiple primaries
using one of the configured primaries, chosen at random. Hence, even with multiple primaries,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miodvallat miodvallat miodvallat approved these changes

Assignees
No one assigned
Labels
auth docs
Projects
None yet
Milestone
auth-5
Development

Successfully merging this pull request may close these issues.
4 participants
@klaus-nicat @coveralls @miodvallat @Habbie