Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "failOnIncompleteCheck" option to if*up Lua functions #15098

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miodvallat
Copy link
Contributor

Short description

This option, is set to "true", will force the if*up Lua functions to return SERVFAIL, rather than applying the backupSelector, if none of the health checks for the targets to check have completed yet.

And you get a few tab->spaces fixes, at no extra charge!

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked all the boxes but the previous one

This option, is set to "true", will force the if*up functions to return
SERVFAIL, rather than applying the backupSelector, if none of the
health checks for the targets to check have completed yet.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13029583812

Details

  • 0 of 28 (0.0%) changed or added relevant lines in 1 file are covered.
  • 42 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.007%) to 64.706%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/lua-record.cc 0 28 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/lua-record.cc 1 0.19%
pdns/validate.cc 1 68.38%
pdns/dnsdistdist/dnsdist-crypto.cc 2 75.72%
pdns/recursordist/aggressive_nsec.cc 2 66.02%
pdns/tsigverifier.cc 3 77.22%
pdns/iputils.hh 3 77.94%
pdns/recursordist/recpacketcache.hh 3 89.55%
pdns/recursordist/syncres.cc 6 80.38%
pdns/recursordist/test-syncres_cc1.cc 7 89.72%
modules/lmdbbackend/lmdbbackend.cc 14 72.75%
Totals Coverage Status
Change from base Build 13005788889: 0.007%
Covered Lines: 127845
Relevant Lines: 166494

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants