rec: check bounds of rcode stats counter index (safe right now) #15139
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safe right now as LWResult::d_rcode gets assigned from the 4 bit rcode in the header. But that might change one day. I'd rather make LWResult::d_rcode an uint8_t, but that causes a conflict with the OOB resolving code that does not make a difference between res and d_rcode.
omoerbeek
force-pushed
the
rec-bound-check-for-future
branch
from
4c2e8cf to
5280f00
Compare
rgacogne
approved these changes
Feb 11, 2025
rgacogne
approved these changes
Feb 11, 2025
Co-authored-by: Remi Gacogne <[email protected]>
omoerbeek
force-pushed
the
rec-bound-check-for-future
branch
from
ae637e8 to
8530269
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safe right now as
LWResult::d_rcodegets assigned from the 4 bitrcodein the header. But that might change one day. I'd rather makeLWResult::d_rcodeanuint8_t, but that causes a conflict with the OOB resolving code that does not make a difference betweenresandd_rcode.Also fix a typo in a constant name and reorder fields in
LWResultlargest to smallest.Short description
Checklist
I have: