Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShellGroup resource #82

Merged
merged 39 commits into from
Jul 19, 2023
Merged

PowerShellGroup resource #82

merged 39 commits into from
Jul 19, 2023

Conversation

anmenaga
Copy link
Collaborator

@anmenaga anmenaga commented Jun 8, 2023

PR Summary

Fix #48
Fix #72
Fix #79

PR Context

Added DSC/PowerShellGroup and DSC/WindowsPowerShellGroup resources.

Supported features:

  • Class-based and script-based (MOF-based) classic PS resources

  • Classic PS resource discovery:
    dsc.exe resource list

  • Configuration Get/Set/Test operations:

Get-Content -raw C:\DSCv3\powershellgroup\testconfig1.yaml| dsc.exe config get
Get-Content -raw C:\DSCv3\powershellgroup\testconfig1.yaml| dsc.exe config set
Get-Content -raw C:\DSCv3\powershellgroup\testconfig1.yaml| dsc.exe config test
  • Get/Set/Test operations on individual resources:
"{'Name':'PSGallery'}" | dsc.exe resource get -r PowerShellGet/MSFT_PSRepository
"{'Path':'./powershellgroup.resource.ps1','Ensure':'Present'}" | dsc.exe resource set -r TestFileDscResource/FileResource
"{'Path':'./powershellgroup.resource.ps1','Ensure':'Present'}" | dsc.exe resource test -r TestFileDscResource/FileResource

WindowsPowerShellGroup supports resource discovery using WindowsPS v5.1 and PSDesiredStateConfiguration v1.1 module; other operations will be added later. This is tracked by #87 .

@anmenaga anmenaga requested a review from SteveL-MSFT June 8, 2023 00:14
dsc/src/main.rs Outdated Show resolved Hide resolved
dsc/src/main.rs Outdated Show resolved Hide resolved
dsc/src/main.rs Show resolved Hide resolved
dsc_lib/Cargo.toml Outdated Show resolved Hide resolved
dsc_lib/src/dscresources/command_resource.rs Outdated Show resolved Hide resolved
dsc_lib/src/dscresources/command_resource.rs Outdated Show resolved Hide resolved
dsc_lib/src/dscresources/dscresource.rs Show resolved Hide resolved
build.ps1 Outdated Show resolved Hide resolved
build.ps1 Outdated Show resolved Hide resolved
build.ps1 Show resolved Hide resolved
dsc/src/main.rs Outdated Show resolved Hide resolved
dsc/src/main.rs Outdated Show resolved Hide resolved
dsc/src/main.rs Show resolved Hide resolved
powershellgroup/Tests/PSTestModule/TestClassResource.psm1 Outdated Show resolved Hide resolved
powershellgroup/Tests/testconfig1.yaml Outdated Show resolved Hide resolved
powershellgroup/powershellgroup.resource.ps1 Show resolved Hide resolved
dsc/src/main.rs Outdated Show resolved Hide resolved
powershellgroup/Tests/testconfig1.yaml Outdated Show resolved Hide resolved
powershellgroup/powershellgroup.resource.ps1 Show resolved Hide resolved
dsc/src/main.rs Outdated Show resolved Hide resolved
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more changes needed

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT SteveL-MSFT merged commit c9539f0 into main Jul 19, 2023
4 checks passed
@SteveL-MSFT SteveL-MSFT deleted the PSGroupResource1 branch July 19, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants