Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dlna searcher is not correctly stoped on macOS and iOS when dialog is dismissed by clicking on the mask #329

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

ErBWs
Copy link
Contributor

@ErBWs ErBWs commented Oct 19, 2024

fix #320
灵光乍现
之前就猜想到是否是dlna未被正常释放。不如说最困扰我的问题是我不知道怎么添加onDismissCallback方法

@Predidit
Copy link
Owner

这是否会导致使用取消按钮退出时的重复停止

@Predidit
Copy link
Owner

此外当我们不需要使用回调值时,应该使用 _ 而不是 value

@ErBWs
Copy link
Contributor Author

ErBWs commented Oct 20, 2024

这是否会导致使用取消按钮退出时的重复停止

这应该是一定会发生的,应该没有实际影响,不过我可以把退出按钮的searcher.stop()删除

此外当我们不需要使用回调值时,应该使用 _ 而不是 value

了解

@ErBWs
Copy link
Contributor Author

ErBWs commented Oct 20, 2024

已经修改

@Predidit Predidit merged commit 97f66b6 into Predidit:main Oct 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: macOS/iOS无法拉起外部播放界面
2 participants