Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 不需要按钮的定位集数功能,全屏现在也可以选集了 #352

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

ErBWs
Copy link
Contributor

@ErBWs ErBWs commented Oct 29, 2024

Screen.mp4

@Predidit
Copy link
Owner

这个PR超棒,不过我们能否先进行一下重构?

  1. 任何情况下,我们都不应该在控制器层直接操作视图层。所以 menuJumpToCurrentEpisode 应该是 videoPage 的方法,而不是 videoController 的方法。observerController 和 animation 也不应该出现在 videoController 中。

  2. player_item.dart 中 1410 行处的修改是为了修复什么问题,看上去语义差不多。

@ErBWs
Copy link
Contributor Author

ErBWs commented Oct 29, 2024

  1. 我再去研究一下
  2. 原来的代码全屏模式会隐藏menu_open的图标,现在的逻辑是非全屏且是手机设备下隐藏该按钮,因为现在全屏也可以打开选集菜单了

@Predidit
Copy link
Owner

问题应该主要在 video_page 和 player_item 的交互上,我们需要从 player_item 通知 video_page tabBar 的变化。我们可以考虑使用 Provider 来处理这一问题。

@ErBWs
Copy link
Contributor Author

ErBWs commented Oct 29, 2024

PlayerItem 是 VideoPage 的子组件,所以我直接把函数传到 PlayerItem 里面了,实现起来会比 Provider 简单一点

@Predidit
Copy link
Owner

感谢你的工作

@Predidit Predidit merged commit f149b95 into Predidit:main Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants