feat: add extend play speed #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我们似乎没有必要为此新增一个开关。 我们可以直接在 macOS/iOS 上不使用拓展。 |
|
我注意到并不是所有视频在 macOS/iOS 上都无法以 2.0 以上的倍速播放，实际上，我在 iOS 上很少遇到无法播放的情况，而在 macOS 上似乎与是否硬件解码有关，因此我认为即使在 macOS/iOS 上也可以允许用户自己选择是否启用不稳定播放速度选项。 |
|
这样的话，我认为可以在 macOS/iOS 上启用硬件解码时不显示拓展部分。 我们还是简洁一些比较好。 |
|
好的，已经修改为根据平台和是否启用硬件解码判断。 |
|
我们不为 iOS 启用吗 |
|
我不确定是否是我的环境问题，我在 iOS 中并没有遇到不支持的 2.0 以上的倍速的情况。 |
|
#226 中的错误就是 iOS 上的错误，我们应该禁用 iOS 硬件解码时 2.0 以上的倍速 |
|
好的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持拓展倍速选项，启用后可以选择可能不支持的 2.0 以上的倍速选项。