Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS/iOS video player improvement #374

Merged
merged 6 commits into from
Nov 6, 2024
Merged

macOS/iOS video player improvement #374

merged 6 commits into from
Nov 6, 2024

Conversation

ErBWs
Copy link
Contributor

@ErBWs ErBWs commented Nov 6, 2024

  1. fix clicli更新之后ios用不了，但之前可以 #360
  2. 关于1.4.1平板横屏ui #366 , 以前的观看模式更好一些，现在太敏感了 #361 的优化
  3. macOS 现在硬件解码注册为 VT，开放 2.0 以上播放倍速，[Bug]: macOS 硬件解码会出现帧表现不正常，如跳帧，重复帧等问题 #358 的 workaround
  4. 规则管理界面的 + 号改为了右上角，floatingActionButton 会挡住一些按钮

@Predidit
Copy link
Owner

Predidit commented Nov 6, 2024 •
edited
Loading

超棒的PR，不过有一个小问题

我们解决 2. 中问题的做法是否有些太粗暴了，特别是响应退出事件时。

这种做法还导致了语义上的问题，无论是否全屏，都会调用至少一次 exitFullscreen 方法

@ErBWs
Copy link
Contributor Author

ErBWs commented Nov 6, 2024

实际上调用两次退出全屏方法是为了在退出界面时让平板可以退出全屏，否则非播放界面也会一直看不到状态栏

不过可以为 pop 时是否退出全屏增加一个平台判断

@Predidit
Copy link
Owner

Predidit commented Nov 6, 2024

我们会在平板竖屏使用时遇到麻烦吗。

看上去现在的写法会在平板锁定竖屏时直接从全屏退出到番剧详情页？

@ErBWs
Copy link
Contributor Author

ErBWs commented Nov 6, 2024 •
edited
Loading

会，因为平板全屏后长这样。不过我不认为会有人用平板竖着看视频就是了
image

@Predidit
Copy link
Owner

Predidit commented Nov 6, 2024

看上去已经没有问题，不过我们应该为 pop 时调用 exitFullscreen 和设置 androidFullscreen 做一下简单的判断，只在 androidFuscreen 为 true 时执行

@ErBWs
Copy link
Contributor Author

ErBWs commented Nov 6, 2024

已经修改

@Predidit Predidit merged commit 30d5f0f into Predidit:main Nov 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clicli更新之后ios用不了，但之前可以
2 participants
@ErBWs @Predidit