Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

press logo jump to history page #382

Merged
merged 2 commits into from
Nov 8, 2024
Merged

press logo jump to history page #382

merged 2 commits into from
Nov 8, 2024

Conversation

ErBWs
Copy link
Contributor

@ErBWs ErBWs commented Nov 8, 2024

  1. 是否可以将设置中的“历史记录”独立出来 #362 , 建议左上角kazumi图标做成历史记录按钮 #341

  2. centerTitle: true 是因为 macOS 不这样设置有的页面标题在左边有的页面标题在中间,Windows 就只会出现在左边。macOS 总有些奇奇怪怪的 bug

@Predidit
Copy link
Owner

Predidit commented Nov 8, 2024

CentralTitle 不符合 material design 设计规范。在可以完美实现靠左的符合规范的其他平台上,使用靠左的标题好一点。

我们应该只在 macOS / iOS 上使用居中标题。和 iOS 当前的UI保持一致

@ErBWs
Copy link
Contributor Author

ErBWs commented Nov 8, 2024

我去阅读了一下 material design 文档,发现只规定了安卓与 iOS 平台 AppBar/Navigation Bar 的标题摆放位置。而在 Apple 开发文档中指出 macOS 没有 Navigation bar,因此标题位置没有明确规定。考虑到代码简洁性我将代码改为了仅 iOS 平台居中摆放,设置为 false 看起来也可以解决 macOS 上摆放不统一的问题

@Predidit Predidit merged commit 4f8ab92 into Predidit:main Nov 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants