Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a gradient background to the top and bottom edges. #395

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add a gradient background to the top and bottom edges. #395

merged 1 commit into from
Nov 15, 2024

Conversation

axlmly
Copy link
Contributor

@axlmly axlmly commented Nov 14, 2024

No description provided.

@Predidit
Copy link
Owner

感谢你的工作，有几个小问题

  1. 934行处判断 showPositioned 的目的是什么，这导致底部阴影会突兀地消失，而不是和顶部阴影一样渐变

  2. 907行处缺少和934行一样的注释

  3. 如果可以的话, commit 信息尽量使用英语，这样和之前的提交保持一致

@axlmly axlmly closed this Nov 15, 2024
@axlmly
Copy link
Contributor Author

axlmly commented Nov 15, 2024

感谢你的工作，有几个小问题

  1. 934行处判断 showPositioned 的目的是什么，这导致底部阴影会突兀地消失，而不是和顶部阴影一样渐变
  2. 907行处缺少和934行一样的注释
  3. 如果可以的话, commit 信息尽量使用英语，这样和之前的提交保持一致

忘删了

@axlmly axlmly changed the title 增加渐变边缘 Add a gradient background to the top and bottom edges. Nov 15, 2024
@axlmly axlmly reopened this Nov 15, 2024
@Predidit
Copy link
Owner

感谢你的工作，这个PR基本上已经没有问题

不过为什么要移除所有的注释，我觉得保留 // 底部渐变半透明区域 这样的简单注释还是有必要的

@Predidit Predidit merged commit 4b51696 into Predidit:main Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axlmly @Predidit