Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix collect button size #595

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix collect button size #595

merged 1 commit into from
Jan 13, 2025

Conversation

ErBWs
Copy link
Contributor

@ErBWs ErBWs commented Jan 12, 2025 •
edited
Loading

之前 collect button 手机上有个小 bug 一直没发现，背景会比 icon 大一圈，这是手机平台独有的问题

@ErBWs ErBWs marked this pull request as ready for review January 12, 2025 17:24
@Predidit
Copy link
Owner

  1. 动态取色的持久化是否存在问题，我主要到 setDynamaicColor 方法中，在启用了 dynamicColor 时似乎不会修改 hive 中的 themeColor，这样我们在下次启动应用时还有动态取色吗。

  2. 当动态取色启用时，我们切换主题色会发生什么，我们会观察到动态取色开关启用，但实际没有动态取色的情况吗。

@ErBWs
Copy link
Contributor Author

ErBWs commented Jan 13, 2025 •
edited
Loading

  1. 持久化确实存在问题，动态配色安卓端获取的不是颜色，这是最麻烦的地方

  2. 动态取色开启后会禁用自定义配色

@ErBWs
Copy link
Contributor Author

ErBWs commented Jan 13, 2025

找不到什么好的办法，也许把存储 Color 改为存储深色及浅色的 ThemeData 可以达成目的

@Predidit
Copy link
Owner

这样会破坏已有的储存结构，我们不应该直接储存 ThemeData

也许我们可以看一下 dynamic_color 的 android 实现部分发生了什么

@ErBWs ErBWs changed the title add dynamic color support fix collect button size Jan 13, 2025
@ErBWs
Copy link
Contributor Author

ErBWs commented Jan 13, 2025

先只修改按钮吧，动态取色之后再研究，fdroid 有更麻烦的问题

@Predidit Predidit merged commit 69a46ef into Predidit:main Jan 13, 2025
6 checks passed
@ErBWs ErBWs deleted the dev branch January 13, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErBWs @Predidit