Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hero transition for bangumi image #657

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

ErBWs
Copy link
Contributor

@ErBWs ErBWs commented Jan 24, 2025

昨天提到了 hero 就去看了眼,感觉非常适合进入 info_page 时海报图的切换,于是就改了

唯一的问题是如果图片被隐藏了部分它的表现就不是特别好

Window-2025-01-24-121142.mp4

@Predidit
Copy link
Owner

Predidit commented Jan 24, 2025

啊,这个效果太棒了,是我想实现但是没能实现的效果

现在 Utils 中还有我当时留下的 makeHeroTag 工具函数

当时认为是 modular 的问题,现在看只要有 transitionOnUserGestures 属性,Hero 一样可以在 modualr 上工作

动画裁剪的问题可以后续再想办法,我目测可能没有太好的方法

@Predidit Predidit merged commit 1094594 into Predidit:main Jan 24, 2025
6 checks passed
@ErBWs ErBWs deleted the feat-hero-image branch January 24, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants