Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Average Precision to metrics #8089

Merged
merged 26 commits into from
Feb 20, 2025

Conversation

thibaultdvx
Copy link
Contributor

Fixes #8085.

Description

Average Precision is very similar to ROCAUC, so I was very much inspired by the ROCAUC implementation.
More precisely, I created:

  • AveragePrecisionMetric and compute_average_precision in monai.metrics,
  • a handler called AveragePrecision in monai.handlers,
  • three unittest modules: test_compute_average_precision.py, test_handler_average_precision.py and test_handler_average_precision_dist.py.

I also modified the docs to mention Average Precision.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

thibaultdvx and others added 9 commits September 17, 2024 11:22
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
Signed-off-by: thibaultdvx <[email protected]>
@thibaultdvx thibaultdvx marked this pull request as ready for review September 17, 2024 11:08
@thibaultdvx
Copy link
Contributor Author

/build

@thibaultdvx
Copy link
Contributor Author

hi @KumoLiu, could you please have a look at this PR?

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr, overall looks good to me.

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too, I had a minor comment and it would be nice to combine the last 2 test files, it would be better to have fewer test files if possible.

@ericspod
Copy link
Member

Hi @thibaultdvx we've updated our tests with a directory structure, if you could please look over comments and update where your test files are we can come back to this PR. Thanks!

@thibaultdvx
Copy link
Contributor Author

Hi @ericspod @KumoLiu, sorry for the absence. I got work and forgot this PR. I'll get right on it!

@thibaultdvx thibaultdvx force-pushed the 8085-average-precision branch from a10d5c6 to 4fc9cf5 Compare February 13, 2025 10:23
Signed-off-by: thibaultdvx <[email protected]>
@thibaultdvx
Copy link
Contributor Author

thibaultdvx commented Feb 13, 2025

@ericspod @KumoLiu ready for review. I don't understand the failing in CI tests, but I'm not sure it is related to my PR.

@ericspod
Copy link
Member

Hi @thibaultdvx I'm going to merge recent changes into your branch and see if that sorts the test issues, I don't think it was related to PR either.

@ericspod
Copy link
Member

I think this is good to go now, @KumoLiu if you could please trigger blossom, thanks.

@KumoLiu
Copy link
Contributor

KumoLiu commented Feb 19, 2025

/build

@KumoLiu
Copy link
Contributor

KumoLiu commented Feb 19, 2025

Hi @thibaultdvx, please help fix the format issue: https://github.com/Project-MONAI/MONAI/actions/runs/13406057032/job/37446075381?pr=8089
Then I will help trigger the test again, thanks!

@KumoLiu
Copy link
Contributor

KumoLiu commented Feb 20, 2025

/build

@KumoLiu KumoLiu enabled auto-merge (squash) February 20, 2025 09:54
@KumoLiu KumoLiu merged commit af54a17 into Project-MONAI:dev Feb 20, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Average Precision and R2 to the metrics
3 participants