-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restormer Implementation #8312
base: dev
Are you sure you want to change the base?
Restormer Implementation #8312
Conversation
…nsample class alias
…pass ./runtests.sh -f -u --net --coverage
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall but I had a few inline comments, and we should have full docstrings everywhere appropriate. For any classes meant for general purpose use (ie. not just by Restormer) please ensure they have docstring descriptions for the arguments (at the very least for constructor args). Thanks!
…ns and simplify ValueError message in pixelunshuffle
…n Restormer model and update assert in forward layer to support 3D images
… Restormer class.
…ument descriptions and error handling details.
…ted changes Signed-off-by: tisalon <[email protected]>
Signed-off-by: tisalon <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: tisalon <[email protected]>
Signed-off-by: tisalon <[email protected]>
Signed-off-by: tisalon <[email protected]>
Signed-off-by: tisalon <[email protected]>
Signed-off-by: tisalon <[email protected]>
Hi @phisanti thanks for bearing with us here but we've updated the tests directory so there's a conflict you'll need to resolve. We've introduced a subdirectory structure within tests so please move your test files to somewhere appropriate within that. Also it appears that a number of changes you've made to address comments have been reverted back, I think somewhere in your commits there's been some mixup of versions. |
Hi @ericspod, no probs. Thanks for the feedback. I will move the test to the appropriate new folder this Friday. Also, I would like to ask for a bit of help if possible. It seems some of the tests cannot be running due to the optional import lineups. For example, it happens in Regarding the mixup on the changes, I think it happened when I did a merge back on Feb 7th as the branch got behind, I will try to look on it. |
Hi @phisanti We can look at the issues with the tests, no problem. I think I should let you figure out the mixup with branches and update your tests first then we can have a look at what the issue is. We should avoid just ignoring tests as much as possible, but if you need einops for example you can use |
Hi @ericspod, I finally manage to find some time to do the merge and be up-to-date with main. Now, in regards with the unit test, I placed them all in their appropriate folders mirroring the structure within source:
I also noticed that I have to move the import of |
… <[email protected]>, I, Cano-Muniz, Santiago <[email protected]>, hereby add my Signed-off-by to this commit: 55da640
Fixes # .
Description
This PR implements the Restormer architecture for high-resolution image restoration in MONAI following the discussion in issue #8261. The implementation supports both 2D and 3D images using MONAI's convolution as the base. Key additions include:
The implementation follows MONAI's coding patterns and includes performance validations against native PyTorch operations where applicable.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.