Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes smartyV3 issues after civix upgrade #420

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

VangelisP
Copy link
Contributor

No description provided.

@VangelisP
Copy link
Contributor Author

Hi @bjendres !
I'll add a few more stuff on this commit and we're good for merging (removal of draft at least)

@VangelisP VangelisP marked this pull request as ready for review June 5, 2024 11:27
@VangelisP
Copy link
Contributor Author

VangelisP commented Jun 5, 2024

This PR is ready for review. The last commit involves a discussion we had with @jensschuppe on #419 (comment) and adds compatibility check for the template variables

Original issue: #415

Copy link
Collaborator

@jensschuppe jensschuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjendres note that this PR is the one that raises the minimum required CiviCRM Core version to 5.60 (dropping support for 5.37).

@jensschuppe jensschuppe merged commit ea74443 into Project60:master Jun 5, 2024
@VangelisP VangelisP deleted the dev-419 branch June 5, 2024 13:12
@jensschuppe jensschuppe added bug status:fixed The issue has been resolved (usually by committing/merging code) labels Jun 25, 2024
@jensschuppe jensschuppe added this to the CiviBanking 1.1 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status:fixed The issue has been resolved (usually by committing/merging code)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants