Year in Membership-ID #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ecoplan-crm. Looks good in general, but could you please create a PR that's only the changes required? It's quite painful to merge check all the indentation changes... |
|
@bjendres You are absolutely right. Sorry for all the formatting changes. I created a new branch in the fork and copied the changes from the actual repo but forgot to check if the formatting was changed. The code should fit now though. |
|
@bjendres any updates on this one? |
Update MembershipExtension.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the possibility to use the year in membership-ids (e.g.
2021-718as id for a membership).