Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slashing upgrade #87

Draft
wants to merge 39 commits into
base: master
Choose a base branch
from
Draft

Slashing upgrade #87

wants to merge 39 commits into from

Conversation

bxmmm1
Copy link
Collaborator

@bxmmm1 bxmmm1 commented Dec 12, 2024

  • Remove unused function
  • Remove dead code
  • Remove useless interfaces for permissioned functions
  • Added a few mainnet fork tests that use PufferVaultV5 to make sure that the interface is the same as what we currently have deployed on the mainnet PufferVaultV3

@bxmmm1 bxmmm1 self-assigned this Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 78.09524% with 46 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mainnet-contracts/src/PufferVaultV5.sol 72.72% 42 Missing ⚠️
mainnet-contracts/src/PufferVaultV2.sol 25.00% 3 Missing ⚠️
mainnet-contracts/src/PufferVault.sol 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
mainnet-contracts/src/L1RewardManager.sol 98.52% <100.00%> (ø)
mainnet-contracts/src/PufferModule.sol 100.00% <100.00%> (ø)
mainnet-contracts/src/PufferModuleManager.sol 95.52% <100.00%> (+12.37%) ⬆️
mainnet-contracts/src/PufferProtocol.sol 94.66% <100.00%> (+0.01%) ⬆️
mainnet-contracts/src/PufferRevenueDepositor.sol 96.15% <100.00%> (ø)
mainnet-contracts/src/PufferVaultStorage.sol 100.00% <ø> (ø)
mainnet-contracts/src/PufferWithdrawalManager.sol 98.27% <100.00%> (ø)
mainnet-contracts/src/RestakingOperator.sol 94.87% <100.00%> (+31.04%) ⬆️
mainnet-contracts/src/ValidatorTicket.sol 86.36% <100.00%> (ø)
mainnet-contracts/src/PufferVault.sol 60.86% <66.66%> (-36.67%) ⬇️
... and 2 more

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant