Skip to content

Commit

Permalink
Remove ninja from build-time deps, use a system edition
Browse files Browse the repository at this point in the history
  • Loading branch information
agriyakhetarpal committed Feb 22, 2024
1 parent 559ef3c commit 1f97532
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ jobs:
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
elif [ "${OPTIONS_NAME}" == "editable-install" ]; then
echo "Testing an editable install of pywt"
pip install numpy==1.26.0 cython meson-python ninja matplotlib pytest
# should we do apt-get install ninja instead and use a system ninja instead?
apt-get install ninja-build
pip install numpy==1.26.0 cython meson-python matplotlib pytest
pip install -e . --no-build-isolation
else
pip install ${PIP_FLAGS} cython
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ build-backend = "mesonpy"
requires = [
"meson-python>=0.14.0",
"Cython>=0.29.35",
"ninja>=1.10.0",

# When numpy 2.0.0rc1 comes out, we should update this to build against 2.0,
# and then runtime depend on the range 1.22.X to <2.3. No need to switch to
Expand Down

0 comments on commit 1f97532

Please sign in to comment.