Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cards instead sections for Key Features portion of front page #538

Merged

Conversation

smokestacklightnin
Copy link
Contributor

@smokestacklightnin smokestacklightnin commented Jan 14, 2025

There was a TODO that said that we want to change the sections on the front page under Key Features to cards. This PR accomplishes that

This PR also fixes links (fix #508) that were broken

@pmeier
Copy link
Member

pmeier commented Jan 14, 2025

Since CI doc builds are still broken, here is the before and after of the front page:

main

image

PR

image

@pmeier pmeier requested a review from pavithraes January 14, 2025 08:07
Copy link
Member

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks William! Let's wait for @pavithraes since she put this TODO comment in.

@pmeier pmeier merged commit a2d7b7d into Quansight:main Jan 14, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Incorrect link on front page
3 participants