-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add GET
endpoints for documents
#547
Open
smokestacklightnin
wants to merge
23
commits into
Quansight:main
Choose a base branch
from
smokestacklightnin:ui/enh/document-viewer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[ENH] Add GET
endpoints for documents
#547
smokestacklightnin
wants to merge
23
commits into
Quansight:main
from
smokestacklightnin:ui/enh/document-viewer
+60
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pmeier
reviewed
Jan 28, 2025
smokestacklightnin
added
type: enhancement 💅
New feature or request
pr-status: in-progress 🏗️
area: web-ui 💻
labels
Jan 29, 2025
smokestacklightnin
changed the title
[ENH] Document Viewer
[ENH] Add Jan 29, 2025
GET
endpoints for documents
All that currently remains for this PR is to add unit tests for the new API endpoints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: rest-api 💻
pr-status: do-not-merge 🛑
Do not merge (yet)
pr-status: in-progress 🏗️
type: enhancement 💅
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #466 and supersedes certain respective parts of #486.
The new endpoints, all using the
GET
method, in this PR are as follow:/documents
/documents/{id}
/documents/{id}/content
Additionally, we now include MIME types in
ragna.core.Document
s.Much of the code in this PR is copied from or inspired by @blakerosenthal's #486