Reworks asset data and improves role system

[joaoburatto]

Summary

This PR reworks the asset data system to not rely on Enums anymore, we now use a DatabaseAsset to recognize each asset and know what to grab. Also has some handy methods to access it easily.

Also improves the role system to ease out the loadout setup process.

Changes to Files

The asset data system has been modified a lot.

Known issues

Something might be broken. I haven't tested every scenario

[stilnat]

did not review the code yet, in the meantime, needs :

• documentation on how to use it (in code and how to create new database and whatever is needed to use it).
• To wait for older PRs using the old asset managment system to be properly reviewed (whether rejected or accepted)
• Should make sure it doesn't have the issue of Spawning ID card and PDA is easily breakable and kicks client when it happens #1136 and therefore closing it.
• Pass the tests (or modify them if necessary)

[stilnat]

Partial review, just one question for now :

What happen if I change the name of an asset and regenerate the database ?

[joaoburatto]

Partial review, just one question for now :

What happen if I change the name of an asset and regenerate the database ?

Currently nothing, I plan to add cleanup when things are removed.

[stilnat]

Partial review : seems like the crafting system is broken. I should see a slice interaction there.

check the "weird complex recipe" and try to reproduce.

[stilnat]

Partial review, just one question for now :
What happen if I change the name of an asset and regenerate the database ?

Currently nothing, I plan to add cleanup when things are removed.

So does the system still works as expected if doing that ?

[joaoburatto]

Partial review, just one question for now :
What happen if I change the name of an asset and regenerate the database ?

Currently nothing, I plan to add cleanup when things are removed.

So does the system still works as expected if doing that ?

It does. The only issue that can happen is unused code.

[stilnat]

the crafting loading bar does not show up when crafting

[stilnat]

Loading asset databases sometimes get stuck and the only way to stop it is to close Unity. need to be fixed. Also it needs to be faster, not instant, but 90 seconds of loading is too long, compared to the current almost instant loading using enums.

[stilnat]

some progress on the pointed issues ?

[joaoburatto]

@stilnat last I checked it was better, but I will still work a little bit to improve it.

[stilnat]

Tried renaming assets, removing them and readding them from database, it seems to work well, crafting, role loadout works well. spawning items too. need to test client.

[stilnat]

Partial review, mostly doc for now to add in a few classes