-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple Game Settings #1281 #1431
Merged
+4,766
−168
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Add UserInterfaceSettings script and fix BandwidthView not showing
commit 48313c615543a7de2c08cf814e8a74b5ea1ba110
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
using UnityEngine; | ||
using UnityEngine.Assertions; | ||
using Coimbra; | ||
using SS3D.Networking.Debug; | ||
using SS3D.Networking.Settings; | ||
|
||
namespace SS3D.UI.Settings | ||
{ | ||
public class UserInterfaceSettings : MonoBehaviour | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A user interface settings class would have more global settings, such as global scale, theme. |
||
{ | ||
[SerializeField] | ||
private GameObject _staminaBar; | ||
private BandwidthView _bandwidthView; | ||
|
||
private bool _enableNetworkBandwidthUsageStats; | ||
|
||
private void Awake() | ||
{ | ||
Assert.IsNotNull(_staminaBar); | ||
_bandwidthView = FindObjectOfType<BandwidthView>(); | ||
_enableNetworkBandwidthUsageStats = | ||
ScriptableSettings.GetOrFind<NetworkSettings>().EnableNetworkBandwidthUsageStats; | ||
} | ||
|
||
public void ToogleStaminaBar(bool isActive) | ||
{ | ||
_staminaBar.SetActive(isActive); | ||
} | ||
|
||
public void ToogleNetworkTrafficInfo(bool isActive) | ||
{ | ||
if (_enableNetworkBandwidthUsageStats) | ||
{ | ||
_bandwidthView.gameObject.SetActive(isActive); | ||
} | ||
} | ||
} | ||
} |
11 changes: 11 additions & 0 deletions
11
Assets/Scripts/SS3D/UI/Settings/UserInterfaceSettings.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this is needed, we already have a ScriptableSettings to add the bandwidth display. I also don't agree at all with having stamina and bandwidth be in the same script in any form, they are not related and if we want to add more stuff it will quickly become a gigantic class.
I really don't see the need for this class at all