[HIPIFY][#1841][build] Add execution permission to hipify-perl
#1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emankov
added
fix
|
@stellaraccident, could you have a look as well? |
nunnikri
reviewed
Feb 6, 2025
| @@ -192,6 +191,7 @@ if (NOT HIPIFY_CLANG_TESTS_ONLY) | |||
| set(HIPIFY_LIBEXEC_INSTALL_PATH "${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBEXECDIR}/hipify") | |||
|
|
|||
| install( | |||
| PROGRAMS ${CMAKE_CURRENT_SOURCE_DIR}/bin/hipify-perl | |||
| PROGRAMS ${CMAKE_CURRENT_SOURCE_DIR}/bin/findcode.sh | |||
| PROGRAMS ${CMAKE_CURRENT_SOURCE_DIR}/bin/findcode_headers.sh | |||
There was a problem hiding this comment.
findcode.sh, findcode_headers.sh, ... are excluded in the old code. do we need to install it now?
There was a problem hiding this comment.
AFAIK they are still being shipped in packages, but even if that is not so now, their removal is not the point of this PR.
…ported by `hipify-clang` lit testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite #1841 based on @raramakr suggestion