Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Broadcom Devices in amd-smi framework #71

Open
wants to merge 11 commits into
base: amd-staging
Choose a base branch
from

Conversation

mcharles-brcm
Copy link

@mcharles-brcm mcharles-brcm commented Jan 26, 2025

As part of this feature,

  1. Added BRCM devices in amd-smi framework
  2. The affected command is 'amd-smi list'
  3. Discovered and added BRCM's NIC and SWITCH devices in the list
  4. The discovery is specific to sysfs entries, which is created by BRCM driver. Hence, without BRCM driver the necessary NIC and SWITCH devices will not be listed in the list command
  5. As of now added BFD and UUID elements added as part of the individual devices

Updated (1/27)

  1. Added BRCM devices as part of amd-smi monitor command
  2. Very limited monitor attributes are added as part of this feature
  3. The affected command is 'amd-smi monitor'
  4. If hwmon sysfs entry not created for the BRCM NIC devices then those controllers are removed from the monitor command
  5. NIC's Monitor Attributes:
    i) NIC_TEMP_CURRENT
    ii) NIC_TEMP_CRIT_ALARM
    iii) NIC_TEMP_EMERGENCY_ALARM
    iv) NIC_TEMP_SHUTDOWN_ALARM
    v) NIC_TEMP_MAX_ALARM
  6. SWITCH's Monitor Attributes:
    i) CURRENT_LINK_SPEED
    ii) MAX_LINK_SPEED
    iii) CURRENT_LINK_WIDTH
    iv) MAX_LINK_WIDTH

mcharles-brcm and others added 4 commits January 24, 2025 16:05
1. As part of this we have added Broadcom's NIC and SWITCH devices in the amd-smi framework.
2. The affected command is 'amd-smi list'
3. Filter the NIC and SWITCH devices based on the Broadcom's vendor ids
4. Since these changes are depending on sysfs entries which is created by broadcom drivers, if no brcm driver present in the system then necessary elements will not created as part of the list command.
NIC/Switch LIST
mcharles-brcm and others added 7 commits January 26, 2025 14:17
As part of this feature,
1. Added monitor attributes for BRCM devices - NIC and SWITCH
2. The affected amd-smi command is 'amd-smi monitor'
3. The list of monitor attributes are read from the corresponding BRCM device's sysfs path
BRCM Monitor
rahulc1984 pushed a commit that referenced this pull request Jan 30, 2025
Fix ordering of RHEL 8 build process

Signed-off-by: Williams, Justin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants