Remove trampolines and all of the associated creaky machinery (and many associated cleanups) #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVlx
requested review from
scchan,
bensander,
gstoner,
aaronenyeshi and
david-salinas
|
@sameerds FYI. |
… to work in async contexts. Use HSA signal information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a catch-all PR which includes many bits alongside the trampoline purging. Things that can be separated shall be separated into compact PRs that focus on a singular aspect (e.g. updating ELFIO or switching over the atomics), but this is presented like so to create a perception of the scope of the work. At the moment it is incomplete, since it's missing
arrayandarray_view, and contains various WiP stubs - I considered it useful to start reviewing early. It goes in tandem with ROCm/hcc-clang-upgrade#148.