cmake: copy hipfft-test third party DLLs to test output dir #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evetsso
requested review from
af-ayala,
eng-flavio-teixeira,
feizheng10 and
malcolmroberts
as code owners
eng-flavio-teixeira
approved these changes
Sep 11, 2024
Kevonosdiaz
approved these changes
Sep 11, 2024
evetsso
merged commit 823b546
into
ROCm:release-staging/rocm-rel-6.3
12 of 17 checks passed
cgmb
reviewed
Sep 12, 2024
There was a problem hiding this comment.
You might find ROCm/rocSOLVER#739 interesting. The TARGET_RUNTIME_DLLS generator expression doesn't work for everything (e.g., rocblas kernel files and some LAPACK dependencies for some reason), but it does seem to capture our intent with this copying.
My proposed change also guards this copying behaviour behind an option (enabled by default), as this copying is somewhat specific to our internal testing workflow and may not be desired by third parties building our software on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick for 6.3 release.