merge docs reorg into docs/6.2.4 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update doc reqs * Update doc reqs * Port hipcc doc reorg to docs/6.2.0 (ROCm#130) * hipcc docs update * minor edit * remove note about llvm * fix syntax * Conditionally skip docs PR build If there is no change to the docs folder or RTD YAML compared to the amd-staging branch --------- Co-authored-by: randyh62 <[email protected]> Co-authored-by: Sam Wu <[email protected]> * change default version from Perl to C++ --------- Co-authored-by: Sam Wu <[email protected]> Co-authored-by: Young Hui - AMD <[email protected]>
samjwu
requested changes
Oct 17, 2024
There was a problem hiding this comment.
this seems to be missing other changes that are in docs/6.2.2
comparison:
https://github.com/randyh62/llvm-project/blob/docs-624/amd/hipcc/docs/sphinx/requirements.in
https://github.com/randyh62/llvm-project/blob/docs-624/openmp/docs/sphinx/requirements.in
vs
https://github.com/ROCm/llvm-project/blob/docs/6.2.2/openmp/docs/sphinx/requirements.in
https://github.com/ROCm/llvm-project/blob/docs/6.2.2/amd/hipcc/docs/sphinx/requirements.in
randyh62
changed the title
samjwu
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update doc reqs
Update doc reqs
Port hipcc doc reorg to docs/6.2.0 (Port hipcc doc reorg to docs/6.2.0 #130)
hipcc docs update
minor edit
remove note about llvm
fix syntax
Conditionally skip docs PR build
If there is no change to the docs folder or RTD YAML compared to the amd-staging branch