[MLIR][OpenMP] Use same helper to translate all loops, NFC #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes the translation of workshare loops also use the `convertLoopNestHelper` function to handle the `omp.loop_nest` wrapped by the corresponding `omp.wsloop` or `omp.distribute` operation.
|
PR stack:
It has been checked to pass Lit and smoke-fort tests. |
|
Thanks Dominik for the review, I just re-created this PR internally. Closing this one. |
kzhuravl
pushed a commit
that referenced
this pull request
Jan 31, 2025
This is a fix for resolving the issue in https://ontrack-internal.amd.com/browse/SWDEV-509197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the translation of workshare loops also use the
convertLoopNestHelperfunction to handle theomp.loop_nestwrapped by the correspondingomp.wslooporomp.distributeoperation.